Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add various final inscription endpoints & refactored some service/dao methods #53

Merged
merged 1 commit into from
Jan 26, 2017

Conversation

MatiasMercado
Copy link
Collaborator

@MatiasMercado MatiasMercado commented Jan 23, 2017

Final Exams

  • Final inscriptions can be listed/created/deleted for a given course.
  • A student that has passed the course can enroll/unenroll into the final exam
  • Verified that 3 failed exams forces the student to take the course again
  • Also: Added several validations for old service & DAO methods.

Trello Card

https://trello.com/c/WEyXOCq6/31-arreglar-agregar-logica-de-finales

@codecov-io
Copy link

codecov-io commented Jan 23, 2017

Current coverage is 9.37% (diff: 0.00%)

Merging #53 into development will decrease coverage by 0.14%

@@           development       #53   diff @@
============================================
  Files               89        90     +1   
  Lines             2500      2539    +39   
  Methods              0         0          
  Messages             0         0          
  Branches           186       192     +6   
============================================
  Hits               238       238          
- Misses            2262      2301    +39   
  Partials             0         0          

Powered by Codecov. Last update 5ec1c79...e2d6198

@gibarsin gibarsin assigned MatiasMercado and unassigned gibarsin Jan 26, 2017
Copy link
Collaborator

@gibarsin gibarsin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well documented code, clean.

@MatiasMercado MatiasMercado merged commit 18ef123 into development Jan 26, 2017
@MatiasMercado MatiasMercado deleted the api_final_inscription branch January 27, 2017 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants