Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend patch number 1 #60

Merged
merged 1 commit into from
Jan 26, 2017
Merged

Backend patch number 1 #60

merged 1 commit into from
Jan 26, 2017

Conversation

gibarsin
Copy link
Collaborator

Summary

A Backend patch has been made to sort the following issues:

  • Remove the repeatNewPassword field from the JSON Request when trying to change a user's password.
  • Change endpoint /login/ for /api/v1/login
  • Remove the ApplicationExceptionMapper because it was catching a Java WS NotFoundException and returning a 500 Server Error instead of a proper 404 Not Found error, so a resource that did not exist would return a 500 error.

Trello Card

https://trello.com/c/gfbIpGWG/44-backend

The current state of the Trello Card shows that issues 1,2,3 in the checklist have been solved.

@MatiasComercio
Copy link
Owner

MatiasComercio commented Jan 26, 2017

@gibarsin Be careful about using # in commit names as Github will auto-link them to PR or issues numbers (check it by yourself by hovering the #1 on your commit message:
image

@codecov-io
Copy link

codecov-io commented Jan 26, 2017

Current coverage is 11.77% (diff: 0.00%)

Merging #60 into development will increase coverage by 0.06%

@@           development        #60   diff @@
=============================================
  Files               95         93     -2   
  Lines             2606       2591    -15   
  Methods              0          0          
  Messages             0          0          
  Branches           192        191     -1   
=============================================
  Hits               305        305          
+ Misses            2301       2286    -15   
  Partials             0          0          

Powered by Codecov. Last update dca63d2...860a38e

@gibarsin
Copy link
Collaborator Author

Commit message has been fixed, i swear it won't happen again @MatiasComercio

@gibarsin gibarsin changed the title Backend patch #1 Backend patch number 1 Jan 26, 2017
A Backend patch has been made to sort the following issues:
- Remove the repeatNewPassword field from the JSON Request when trying to change a user's password.
- Change endpoint /login/ for /api/v1/login
- Remove the ApplicationExceptionMapper because it was catching a Java WS NotFoundException and returning a 500 Server Error instead of a proper 404 Not Found error, so a resource that did not exist would return a 500 error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants