Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add usersAuthorities to /users #61

Merged
merged 1 commit into from
Jan 27, 2017
Merged

Conversation

MatiasMercado
Copy link
Collaborator

@MatiasMercado MatiasMercado commented Jan 27, 2017

Authorities

User's authorities can now be accessed in /users.
This will return a list containing both the action available and it's location.

Trello Card

https://trello.com/c/ZfO06JhK/23-send-user-authorities

@codecov-io
Copy link

Current coverage is 11.64% (diff: 0.00%)

Merging #61 into development will decrease coverage by 0.12%

@@           development        #61   diff @@
=============================================
  Files               93         95     +2   
  Lines             2591       2619    +28   
  Methods              0          0          
  Messages             0          0          
  Branches           191        192     +1   
=============================================
  Hits               305        305          
- Misses            2286       2314    +28   
  Partials             0          0          

Powered by Codecov. Last update ef7923c...3d41053

Copy link
Collaborator

@gibarsin gibarsin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks ok.
The "ROLE_" prefix can be spared, because it was added every time the authorities were obtained.
The authoritiesMap should go to another class, maybe a wrapper class or a table (inclined more to a wrapper)

@MatiasMercado MatiasMercado merged commit ef09424 into development Jan 27, 2017
@gibarsin gibarsin deleted the users_authorities branch January 27, 2017 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants