Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Current User to front end #74

Merged
merged 2 commits into from
Feb 2, 2017
Merged

Conversation

MatiasComercio
Copy link
Owner

Summary

  • Add navDataService methods to handle current user load
    • Add current user fecthed from real API throught Restangular
      decorator
  • Update style when user is not logged in
  • Update specs to match new functionality
    • Update LoginCtrl.spec
    • Update NavbarDirective.spec
    • Update navDataService.spec
  • Other changes
    • Fix responsive meta tag missing

Trello Card

https://trello.com/c/gY5L7nW6/60-getear-current-user-con-sus-authorities-restangular

- Add navDataService methods to handle current user load
  - Add current user fecthed from real API throught Restangular
    decorator
- Update style when user is not logged in
- Update specs to match new functionality
  - Update LoginCtrl.spec
  - Update NavbarDirective.spec
  - Update navDataService.spec
- Other changes
  - Fix responsive meta tag missing
Copy link
Owner Author

@MatiasComercio MatiasComercio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, fix the codestats issues.

function(paw) {
paw.controller('BodyCtrl', [function() {
paw.controller('BodyCtrl', ['navDataService', function(navDataService) {
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should be adding a test case for this too.

var memory = memoryFactory.newMemory();
var userKey = 'user';

// var rest = AuthenticatedRestangular;
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this line

- Fix codestat issues
- Add spec case for BodyCtrl
@MatiasComercio MatiasComercio merged commit 68ea41d into development Feb 2, 2017
@MatiasComercio MatiasComercio deleted the current-user-front branch February 2, 2017 19:49
MatiasComercio added a commit that referenced this pull request Feb 5, 2017
- Add navDataService methods to handle current user load
  - Add current user fecthed from real API throught Restangular
    decorator
- Update style when user is not logged in
- Update specs to match new functionality
  - Update LoginCtrl.spec
  - Update NavbarDirective.spec
  - Update navDataService.spec
  - Update BodyCtrl.spec

- Other changes
  - Fix responsive meta tag missing
  - Fix codestat issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant