Add logout functionality #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatiasComercio
commented
Feb 2, 2017
app/specs/directives/navbar.spec.js
Outdated
| }); | ||
|
|
||
| it('redirects to the login page', function() { | ||
| expect($location.path).toHaveBeenCalledWith('/login'); |
There was a problem hiding this comment.
You should be using the Paths service, not hardcoded URLs
- Update Authentication.spec - Update memoryFactory.spec - Update navbar.spec - Notes - Logout is implemented on the navbar directive
MatiasComercio
force-pushed
the
add-logout
branch
from
dfa3e13
to
a0a0af9
Compare
Merged
MatiasComercio
added a commit
that referenced
this pull request
Feb 5, 2017
- Update Authentication.spec - Update memoryFactory.spec - Update navbar.spec - Notes - Logout is implemented on the navbar directive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Notes
Trello Card
https://trello.com/c/6w6HRgpn/62-agregar-logout-controller