Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: merge staging to master #67

Merged
merged 4 commits into from
Jun 29, 2022
Merged

ci: merge staging to master #67

merged 4 commits into from
Jun 29, 2022

Conversation

MatrixAI-Bot
Copy link
Member

This is an automatic PR generated by the pipeline CI/CD. This will be automatically fast-forward merged if successful.

emmacasolin and others added 4 commits June 29, 2022 14:16
We can use jest's `shard` option to implement test load balancing. This required updating to jest v28, as sharding was introduced in this version.
For now the shard count is chosen manually and is statically set, however, this may be optimised in the future.
Test load balancing is now utilised for both `test` and `build` (platform) pipelines.
Changed the options for junit reporting to better organise the tests.
Tests will now be displayed in Gitlab with the top-level describe, test name, and file path.
feat: test load balancing using jest's `--shard` option
@MatrixAI-Bot MatrixAI-Bot self-assigned this Jun 29, 2022
@MatrixAI-Bot
Copy link
Member Author

@ghost
Copy link

ghost commented Jun 29, 2022

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@CMCDragonkai
Copy link
Member

Are you not using a custom test sequencer?

@MatrixAI-Bot
Copy link
Member Author

@MatrixAI-Bot MatrixAI-Bot merged commit f450a32 into master Jun 29, 2022
@github-pages github-pages bot temporarily deployed to github-pages June 29, 2022 05:20 Inactive
@emmacasolin
Copy link
Contributor

Are you not using a custom test sequencer?

No, it's not needed since we're using the default.

@CMCDragonkai
Copy link
Member

Apologies, the review came in after this is already merged, it should have been addressed in #65, however we're rushing to get some features into PK.

So all of those review comment should be addressed in another commit to staging and simultaneously your work on PK MatrixAI/Polykey#392

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants