-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Table A3.2 not fully loading #34
Comments
a3_2 <- readrba::read_rba("A3.2")
# These are the series IDs in the A3.2 spreadsheet
rba_series <- c(
"RBASLI",
"RBASLISIN",
"RBASLCR",
"RBASLMD",
"RBASLFV",
"RBASLT",
"RBASWI",
"RBASWISIN",
"RBASWCR",
"RBASWMD",
"RBASWFV"
)
# These are the series IDs in the spreadsheet that are not in our tibble
rba_series[!rba_series %in% unique(a3_2$series_id)]
#> [1] "RBASLI" "RBASLISIN" "RBASWI" "RBASWISIN" Created on 2022-05-16 by the reprex package (v2.0.1) |
The problem is that several series in table A3.2 are non-numeric. |
I think the conceptual problem is that this data is already 'tidy', unlike other RBA sheets. Each row is an observation, each column a variable. |
Thanks for taking a look Matt. I've just discovered the same issue appears for several series in Stat Table A3 as well (e.g. for "OMO outright transaction detail" and "Bond Purchase Program"). The problem looks to be the same as the issue for A3.2 - the data is already tidied. Sorry if you've already noticed this too. |
Thanks @cromj006! I wasn't aware of that - thanks for letting me know. I'm torn between three options here:
|
@MattCowgill option 2 sounds good to me, but I of course don't know if there would be consequences of this more broadly. Option 3 sounds like it could work too if you were somehow able to add the |
thanks @cromj006. I am drawn to option 2 as well. My hesitation is just that it would return quite a different-looking tibble for A3.2 (etc) than for other RBA tables. I like the fact that |
After thinking about this some more, I don't like option (2) because it would return an object different to the one you usually get when you call |
… != the number of columns (except the first col) in the raw Excel file - see #34
Tables that appear to have an issue in which the number of unique series IDs in the tibble returned by
|
This should result in 11 unique series, not 7:
Created on 2022-05-16 by the reprex package (v2.0.1)
Thanks to Matt Crocker for reporting this issue via email
The text was updated successfully, but these errors were encountered: