Skip to content

Commit

Permalink
Remove comment numbers
Browse files Browse the repository at this point in the history
  • Loading branch information
roed314 committed Feb 8, 2023
1 parent 18c3c71 commit 27cdf3e
Show file tree
Hide file tree
Showing 24 changed files with 27 additions and 27 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci-wsl.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
windows:
runs-on: windows-latest
name: Ubuntu 20.04
# Following https://github.com/sagemath/sage/issues/25206#comment:63
# Following https://github.com/sagemath/sage/issues/25206
steps:
- name: Configure git
run: git config --global core.symlinks true
Expand Down
2 changes: 1 addition & 1 deletion build/pkgs/ecl/SPKG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ Special Update/Build Instructions

- Do NOT quote SAGE_LOCAL when setting CPPFLAGS and/or LDFLAGS,
in spkg-install as this caused the build to break. See
https://github.com/sagemath/sage/issues/10187#comment:117
https://github.com/sagemath/sage/issues/10187

- TODO: Add the ECL test suite, and an spkg-check file to run it.
- TODO: Make ECL use Sage's Boehm GC on MacOS X as well (but perhaps
Expand Down
4 changes: 2 additions & 2 deletions build/pkgs/ecm/spkg-install.in
Original file line number Diff line number Diff line change
Expand Up @@ -92,10 +92,10 @@ else
# Don't add debug symbols because configure otherwise
# fails due to a bus error in Apple's 'ld' when trying
# to determine if global symbols are prefixed with an
# underscore (cf. https://github.com/sagemath/sage/issues/5847#comment:35 ff.):
# underscore (cf. https://github.com/sagemath/sage/issues/5847 ff.):
echo >&2 "Warning: Disabling debug symbols on MacOS X 10.5" \
"PowerPC because of a linker (?) bug."
echo >&2 "See https://github.com/sagemath/sage/issues/5847#comment:35" \
echo >&2 "See https://github.com/sagemath/sage/issues/5847" \
"ff. for details."
echo >&2
CFLAGS="-O3 $ORIGINAL_CFLAGS"
Expand Down
2 changes: 1 addition & 1 deletion build/pkgs/fflas_ffpack/spkg-install.in
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ if [ -z "$CONFIG_SHELL" ]; then
fi

# We disable openmp because of build failures, see
# https://github.com/sagemath/sage/issues/17635#comment:67
# https://github.com/sagemath/sage/issues/17635
sdh_configure --with-default="$SAGE_LOCAL" --with-blas-libs="$LINBOX_BLAS" \
"$LINBOX_BLAS_CFLAGS" --disable-static \
--enable-precompilation $FFLAS_FFPACK_CONFIGURE
Expand Down
2 changes: 1 addition & 1 deletion build/pkgs/gap/spkg-install.in
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ sdh_install pkg/GAPDoc-* pkg/primgrp-* pkg/SmallGrp-* pkg/transgrp "$GAP_ROOT"/p
# typically "expected" to be loaded: These are the default packages that are
# autoloaded at GAP startup (via the PackagesToLoad UserPreference) with an
# out-of-the-box GAP installation; see
# https://github.com/sagemath/sage/issues/22626#comment:393 for discussion on this
# https://github.com/sagemath/sage/issues/22626 for discussion on this
#
# Also include atlasrep which is a dependency of tomlib
sdh_install \
Expand Down
2 changes: 1 addition & 1 deletion build/pkgs/gdb/distros/conda.txt
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
# Disabled for now because of https://github.com/sagemath/sage/issues/30845#comment:269
# Disabled for now because of https://github.com/sagemath/sage/issues/30845
# gdb
2 changes: 1 addition & 1 deletion build/pkgs/glpk/patches/error_recovery.patch
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
From: Jeroen Demeyer
Allow error recovery. See discussion at
https://github.com/sagemath/sage/issues/20710#comment:18
https://github.com/sagemath/sage/issues/20710

diff --git a/src/env/error.c b/src/env/error.c
index a898b76..154de0f 100644
Expand Down
4 changes: 2 additions & 2 deletions build/pkgs/glpk/spkg-install.in
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
cd src/

# Use newer version of config.guess and config.sub (see Trac #19713)
# Use newer version of config.guess and config.sub (see Github issue #19713)
cp "$SAGE_ROOT"/config/config.* .

# Note: The following doesn't work with spaces in `$SAGE_LOCAL`, but we don't
Expand All @@ -26,7 +26,7 @@ sdh_configure --with-gmp --disable-static
sdh_make

# Remove old libraries to make sure we can downgrade it if needed.
# See https://github.com/sagemath/sage/issues/23596#comment:4 and later.
# See https://github.com/sagemath/sage/issues/23596.
rm -f "$SAGE_LOCAL"/lib/libglpk.*

sdh_make_install
2 changes: 1 addition & 1 deletion build/pkgs/linbox/spkg-install.in
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ fi
LINBOX_CONFIGURE="--without-fplll $LINBOX_CONFIGURE"

# We disable openmp because of build failures, see
# https://github.com/sagemath/sage/issues/17635#comment:67
# https://github.com/sagemath/sage/issues/17635
# We disable ocl because of build failures, see
# https://github.com/sagemath/sage/issues/32076
sdh_configure --with-default="$SAGE_LOCAL" \
Expand Down
2 changes: 1 addition & 1 deletion build/pkgs/maxima/spkg-install.in
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Sometimes, ECL gives interactive prompts when something goes wrong
# during the build. Avoid this by redirecting stdin from /dev/null.
# See https://github.com/sagemath/sage/issues/11884#comment:34
# See https://github.com/sagemath/sage/issues/11884
exec </dev/null


Expand Down
2 changes: 1 addition & 1 deletion build/pkgs/meataxe/spkg-install.in
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
# marked as installed but the run-time check for the matrix_gfpn_dense
# module checks whether it can be imported. We need to ensure that these
# two conditions are equivalent, otherwise strange things can happen.
# See also https://github.com/sagemath/sage/issues/24359#comment:154
# See also https://github.com/sagemath/sage/issues/24359
#
# This also deletes the static library left behind from the installation
# of MeatAxe (as opposed to SharedMeatAxe).
Expand Down
2 changes: 1 addition & 1 deletion build/pkgs/numpy/spkg-install.in
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ if [ `uname` = "Darwin" ]; then
unset ATLAS
unset BLAS
unset LAPACK
# https://github.com/sagemath/sage/issues/34110#comment:35
# https://github.com/sagemath/sage/issues/34110
# The fix for "reciprocal" (affected by a clang compiler bug) in
# https://github.com/numpy/numpy/pull/19926 relies on -ftrapping-math
# being used when Apple clang v12+ is used.
Expand Down
2 changes: 1 addition & 1 deletion build/pkgs/ptyprocess/install-requires.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
ptyprocess ==0.5.1
# https://github.com/sagemath/sage/issues/31280#comment:42 and following
# https://github.com/sagemath/sage/issues/31280
# sagelib is not compatible with ptyprocess 0.5.2, 0.6, and 0.7
2 changes: 1 addition & 1 deletion build/sage_bootstrap/uncompress/tar_file.py
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ class SageBaseTarFile(tarfile.TarFile):
time (the current time), not the timestamps stored in the tarball. This
is meant to work around https://bugs.python.org/issue32773
See https://github.com/sagemath/sage/issues/20218#comment:16 and
See https://github.com/sagemath/sage/issues/20218 and
https://github.com/sagemath/sage/issues/24567 for more background.
"""

Expand Down
2 changes: 1 addition & 1 deletion src/sage/arith/constants.pxd
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# float. We use these instead of decimal constants like 3.1415...
# because the hex floats are exactly representable as "double", so there
# shouldn't be any rounding issues in the compiler.
# See https://github.com/sagemath/sage/issues/23919#comment:15
# See https://github.com/sagemath/sage/issues/23919
#
# Hex floats are standardized in C99, but GCC accepts them
# unconditionally, also for C++ code.
Expand Down
2 changes: 1 addition & 1 deletion src/sage/arith/long.pxd
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,7 @@ cdef inline bint integer_check_long_py(x, long* value, int* err):
# - BITS_IN_LONG = 63, PyLong_SHIFT = 30
# - BITS_IN_LONG = 31, PyLong_SHIFT = 15 (python <= 3.10)
# - BITS_IN_LONG = 31, PyLong_SHIFT = 30 (new in python 3.11)
# cf. https://github.com/sagemath/sage/issues/33842#comment:130
# cf. https://github.com/sagemath/sage/issues/33842
#
# This way, we know that 1 digit certainly fits in a C long
# and 4 or more digits never fit.
Expand Down
2 changes: 1 addition & 1 deletion src/sage/combinat/finite_state_machine.py
Original file line number Diff line number Diff line change
Expand Up @@ -4887,7 +4887,7 @@ def key_function(s):
return (s.from_state, s.to_state)
# We use an OrderedDict instead of a dict in order to have a
# defined ordering of the transitions in the output. See
# https://github.com/sagemath/sage/issues/16580#comment:3 . As the
# https://github.com/sagemath/sage/issues/16580. As the
# transitions have to be sorted anyway, the performance
# penalty should be bearable; nevertheless, this is only
# required for doctests.
Expand Down
2 changes: 1 addition & 1 deletion src/sage/cpython/atexit.pyx
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ cdef class restore_atexit:
sage: import atexit
sage: from sage.cpython.atexit import restore_atexit
sage: def handler(*args, **kwargs):
....: import sys # see https://github.com/sagemath/sage/issues/25270#comment:56
....: import sys # see https://github.com/sagemath/sage/issues/25270
....: sys.stdout.write(str((args, kwargs)))
....: sys.stdout.write('\n')
sage: atexit.register(handler, 1, 2, c=3)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
(0 : 1 : 0)
sage: 3000000000000001 * M.0
(4 : -7 : 1)
sage: M == loads(dumps(M)) # known bug, see https://github.com/sagemath/sage/issues/sage_trac/ticket/11599#comment:7
sage: M == loads(dumps(M)) # known bug, see https://github.com/sagemath/sage/issues/sage_trac/ticket/11599
True
TESTS:
Expand Down
2 changes: 1 addition & 1 deletion src/sage/matrix/matrix_polynomial_dense.pyx
Original file line number Diff line number Diff line change
Expand Up @@ -781,7 +781,7 @@ cdef class Matrix_polynomial_dense(Matrix_generic_dense):
2021), it would be highly beneficial to use conversions and rely on
polynomials with matrix coefficients when the matrix size is
"large" and the degree "small", see
:trac:`31472#comment:5`.
:trac:`31472`.
"""
if d <= 0:
raise ValueError("the precision must be positive")
Expand Down
2 changes: 1 addition & 1 deletion src/sage/misc/compat.py
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ def _find_library(name):
elif sys.platform == 'darwin':
# On OSX non-standard library paths are not automatically found by the
# find_library implementation without setting DYLD_LIBRARY_PATH; see
# https://github.com/sagemath/sage/issues/21399#comment:25
# https://github.com/sagemath/sage/issues/21399
from ctypes.util import find_library as _orig_find_library

def _find_library(name):
Expand Down
2 changes: 1 addition & 1 deletion src/sage/schemes/elliptic_curves/ell_field.py
Original file line number Diff line number Diff line change
Expand Up @@ -988,7 +988,7 @@ def division_field(self, l, names='t', map=False, **kwds):

verbose("Adjoining Y-coordinates of %s-torsion points" % l)

# THEOREM (Cremona, https://github.com/sagemath/sage/issues/11905#comment:21).
# THEOREM (Cremona, https://github.com/sagemath/sage/issues/11905).
# Let K be a field, E an elliptic curve over K and p an odd
# prime number. Assume that K contains all roots of the
# p-division polynomial of E. Then either K contains all
Expand Down
2 changes: 1 addition & 1 deletion src/sage/schemes/elliptic_curves/ell_torsion.py
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ def __init__(self, E):
sage: type(T)
<class 'sage.schemes.elliptic_curves.ell_torsion.EllipticCurveTorsionSubgroup_with_category'>
sage: T == loads(dumps(T)) # known bug, see https://github.com/sagemath/sage/issues/11599#comment:7
sage: T == loads(dumps(T)) # known bug, see https://github.com/sagemath/sage/issues/11599
True
"""
self.__E = E
Expand Down
4 changes: 2 additions & 2 deletions src/sage_docbuild/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -109,11 +109,11 @@ def build_many(target, args, processes=None):
least two known issues:
* On versions of Cygwin prior to 3.0.0 there were bugs in mmap handling
on threads (see :trac:`27214#comment:25`).
on threads (see :trac:`27214`).
* When PARI is built with multi-threading support, forking a Sage
process from a thread leaves the main Pari interface instance broken
(see :trac:`26608#comment:38`).
(see :trac:`26608`).
In the future this may be replaced by a generalized version of the more
robust parallel processing implementation from ``sage.doctest.forker``.
Expand Down

0 comments on commit 27cdf3e

Please sign in to comment.