Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch CI to GitHub actions #178

Merged
merged 9 commits into from
Mar 24, 2021
Merged

Switch CI to GitHub actions #178

merged 9 commits into from
Mar 24, 2021

Conversation

maxfischer2781
Copy link
Member

This PR switches the CI from Travis to GitHub actions.

Closes actions/toolkit#176.

@giffels giffels added the Improvement Code Improvements label Mar 23, 2021
@maxfischer2781
Copy link
Member Author

After fixing up the test setup for PyPy3, it looks like TARDIS almost supports it. There appears to be an issue with handling SQLite3.

_sqlite3.OperationalError: database is locked

@codecov-io
Copy link

Codecov Report

Merging #178 (28e2457) into master (d989653) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     actions/toolkit#178   +/-   ##
=======================================
  Coverage   99.54%   99.54%           
=======================================
  Files          43       43           
  Lines        1769     1769           
=======================================
  Hits         1761     1761           
  Misses          8        8           
Impacted Files Coverage Δ
setup.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d989653...28e2457. Read the comment docs.

@maxfischer2781
Copy link
Member Author

I've removed pypy3 for the time being, since the reporting of ontinue-on-error is intransparent. See also actions/runner#2347

@maxfischer2781 maxfischer2781 mentioned this pull request Mar 23, 2021
@maxfischer2781
Copy link
Member Author

Deferred the PyPy3 issue. See actions/toolkit#179.

@maxfischer2781 maxfischer2781 marked this pull request as ready for review March 23, 2021 19:33
eileen-kuehn
eileen-kuehn previously approved these changes Mar 24, 2021
Copy link
Member

@eileen-kuehn eileen-kuehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, even the badges have the correct links :)

@giffels giffels added this to the 0.6.0 - Release milestone Mar 24, 2021
Copy link
Member

@giffels giffels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot of your awesome work. I have only one little change to request. Could you remove the .travis.yaml as well, please?

eileen-kuehn
eileen-kuehn previously approved these changes Mar 24, 2021
Copy link
Member

@eileen-kuehn eileen-kuehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Go for it 🥳

Copy link
Member

@giffels giffels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you apply the suggested change, please?

.github/workflows/verification.yml Outdated Show resolved Hide resolved
Copy link
Member

@giffels giffels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your awesome contribution. I am happy that CI has now moved to GitHub actions. Tests are very fast now!

Copy link
Member

@eileen-kuehn eileen-kuehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still great ;)

@maxfischer2781 maxfischer2781 merged commit 40068e4 into master Mar 24, 2021
@giffels giffels deleted the maintenance/gh-actions branch March 24, 2021 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Code Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants