Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure python3.10 compatibility #213

Merged
merged 1 commit into from
Oct 11, 2021

Conversation

giffels
Copy link
Member

@giffels giffels commented Oct 6, 2021

This pull request enables Python 3.10 unittests, adds 3.10 as supported release into setup.py and fixes a few deprecation warnings occuring when executing unittests under 3.10.

@giffels giffels marked this pull request as ready for review October 7, 2021 07:56
@giffels giffels requested review from a team, maxfischer2781 and RHofsaess and removed request for a team October 7, 2021 07:56
Copy link
Member

@maxfischer2781 maxfischer2781 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

max.get_review_approval_policy().get_review_approval()

@giffels giffels merged commit 2afcbd4 into MatterMiners:master Oct 11, 2021
@giffels giffels deleted the python3.10-compat branch October 11, 2021 14:55
giffels added a commit to giffels/tardis that referenced this pull request Apr 19, 2022
giffels added a commit to giffels/tardis that referenced this pull request Jan 20, 2023
giffels added a commit to giffels/tardis that referenced this pull request Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants