Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docker container for deployment tests #226

Merged
merged 2 commits into from
Feb 3, 2022
Merged

Update docker container for deployment tests #226

merged 2 commits into from
Feb 3, 2022

Conversation

giffels
Copy link
Member

@giffels giffels commented Jan 28, 2022 •
edited
Loading

This pull request

  • updates the rockylinux container to use the offcial dockerhub repository
  • deprecates the deployment test on Centos 8, since it is EOL
  • adds a deployment test on Centos Stream 8 as replacement.

@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2022 •
edited
Loading

Codecov Report

Merging #226 (b22bc3b) into master (d66c293) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #226   +/-   ##
=======================================
  Coverage   99.56%   99.56%           
=======================================
  Files          41       41           
  Lines        1823     1823           
=======================================
  Hits         1815     1815           
  Misses          8        8

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d66c293...b22bc3b. Read the comment docs.

@giffels giffels changed the title Use new rockylinux dockerhub repo Update docker container for deployment tests Jan 28, 2022
@giffels giffels marked this pull request as ready for review January 28, 2022 14:09
@giffels giffels requested review from a team, maxfischer2781 and eileen-kuehn and removed request for a team January 28, 2022 14:20
eileen-kuehn
eileen-kuehn approved these changes Jan 28, 2022
View reviewed changes
Copy link
Member

@eileen-kuehn eileen-kuehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my point of view, go for it 👍

@giffels giffels merged commit eb1e91c into MatterMiners:master Feb 3, 2022
@giffels giffels deleted the update-deployment-tests branch February 3, 2022 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxfischer2781 maxfischer2781 maxfischer2781 approved these changes

@eileen-kuehn eileen-kuehn eileen-kuehn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@giffels @codecov-commenter @maxfischer2781 @eileen-kuehn