Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing libgcc for cryptography #229

Merged
merged 1 commit into from
Feb 24, 2022

Conversation

giffels
Copy link
Member

@giffels giffels commented Feb 23, 2022

As reported by @stefan-k on Mattermost, libgcc is missing in the cobald-tardis container, which is necessary for the cryptography python package.

This pull request adds libgcc to the image.

@giffels giffels requested review from a team, maxfischer2781 and mschnepf and removed request for a team February 23, 2022 08:36
Copy link
Member

@mschnepf mschnepf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides I do not understand why @maxfischer2781 is now above me in the list of contributed ;-) that looks good. Thanks for taking care of it. :-)

@giffels
Copy link
Member Author

giffels commented Feb 23, 2022

Besides I do not understand why @maxfischer2781 is now above me in the list of contributed ;-) that looks good. Thanks for taking care of it. :-)

@maxfischer2781 made a lot of commits recently, so you have to catch up again. ;-)

Copy link
Member

@maxfischer2781 maxfischer2781 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that's what I call a tough review!

@giffels giffels merged commit 75b60e3 into MatterMiners:master Feb 24, 2022
@giffels giffels deleted the fix-container branch February 24, 2022 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants