-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maintenance for AsyncBulkCall #238
Maintenance for AsyncBulkCall #238
Conversation
@giffels The newest flake8-bugbear release adds B019, which does not like our use of LRU caches on methods. Should I disable the check? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have just one comment/question, But nothing critical. Thanks for your work 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the change. Now it is less confusing. Merge it so 🖖
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine. Thanks for your work.
Yes, please disable it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your work. I will merge it once B019
is disabled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your work! This PR is ready to meeeeeerrrrrrggggeeee! ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
This PR fixes some internal issues of
AsyncBulkCall
. Major changes include:task_done
for each item read from the queueCloses #232.
Note: I considered cleaning up the dispatch task via a callback, the way bulk tasks are cleaned up. However, I could not find guarantees on promptness so had to assume using a callback may introduce a race between shutting down
_bulk_dispatch
and__call__
detecting that it needs to restart dispatch.