Fix sqlite3 remote_resource_uuid update #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giffels
force-pushed
the
fix-sqlite-updates
branch
from
890f00c
to
bff7dbe
Compare
Codecov Report
@@ Coverage Diff @@
## master #249 +/- ##
=======================================
Coverage 99.34% 99.34%
=======================================
Files 54 54
Lines 2145 2145
=======================================
Hits 2131 2131
Misses 14 14
Continue to review full report at Codecov.
|
giffels
requested review from
maxfischer2781,
a team and
RHofsaess
and removed request for
a team
maxfischer2781
previously approved these changes
May 25, 2022
docs/source/changes/249_fix_sqlite_registry_remote_uuid_update.yaml
Outdated
Show resolved
Hide resolved
….yaml Co-authored-by: Max Fischer <maxfischer2781@gmail.com>
Thanks a lot, I fixed it. |
maxfischer2781
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing #247 revealed a bug in TARDIS. The
remote_resource_uuidin theSqliteRegistryplugin in not updated at all. As a result, TARDIS keeps crashing on restarts due to the missingremote_resource_uuiduntil the DB has been removed.This pull request add the missing
remote_resource_uuidattribute to the update database calls and fixes #248.