Fix Python3.6 unittest by using ubuntu 20.04 #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 98.88% // Head: 98.88% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #272 +/- ##
=======================================
Coverage 98.88% 98.88%
=======================================
Files 56 56
Lines 2325 2325
=======================================
Hits 2299 2299
Misses 26 26
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
giffels
requested review from
a team,
eileen-kuehn and
rfvc
and removed request for
a team
maxfischer2781
approved these changes
Dec 7, 2022
|
Great! Just for reference, the versions of Python available in the Ubuntu 20.04-runner and for Ubuntu 22.04 |
rfvc
approved these changes
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to actions/runner-images#6399 GitHub's run-on
ubuntu-latesttag is now pointing to Ubuntu 22.04. However, this version does not offer a Python 3.6 interpreter according to actions/setup-python#544. This will break our unittest for the good old Python 3.6 version.This pull request forces GitHub actions to use Ubuntu 20.04 instead, which still supports Python 3.6. Just another hint that it is time to get rid of it. 😌
In addition, the newest flake checks for PEP-618, which is only supported for Python>=3.10. Hence, I have disabled the checks on the concerned lines.