Fix flake8 B907 errors

[giffels]

In recent flake8 tests it complains (B907) about three code lines using the mechanism f'Test="{bla}"' to put the value of a variable into double quotes to be executed in a shell. The documentation suggest to change this into f"Test={bla!r}", which leads to a slightly different output Test='value' instead of Test="value". However, this does not matter for the execution of the concerned commands in a shell.

For the third occuarance I decided to ignore that error, since it mimics the output of a moab command in a unittest, which uses double quotes.

[mschnepf]

Looks fine to me 👍

[codecov-commenter]

Codecov Report

Base: 98.88% // Head: 98.88% // No change to project coverage 👍

Coverage data is based on head (713cfa3) compared to base (248cd6e).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #279   +/-   ##
=======================================
  Coverage   98.88%   98.88%           
=======================================
  Files          56       56           
  Lines        2328     2328           
=======================================
  Hits         2302     2302           
  Misses         26       26           

Impacted Files	Coverage Δ
tardis/adapters/sites/slurm.py	100.00% <ø> (ø)
tardis/plugins/auditor.py	100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[maxfischer2781]

FWIW, I would be fine with disabling this check. We often want/need a specific kind of quote and formatting and !r is not at all equivalent. For example, it will also escape linebreaks, tabs and similar.

Alternatively, we might want to use shlex.quote when the target is a shell (which should be the case for all executors).

[mschnepf]

Looks fine for me 👍

[maxfischer2781]

@giffels Just a heads up that @eileen-kuehn is waiting (without rushing) whether you would want to change the PR in response to my comment above.

[giffels]

@giffels Just a heads up that @eileen-kuehn is waiting (without rushing) whether you would want to change the PR in response to my comment above.

I will change the pull request tomorrow. I think I am going to ignore B907 then.

[eileen-kuehn]

Looks good to me, go for it 👍

[mschnepf]

Looks fine to me. 👍
Go ahead