-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix handling of job ids in Lancium adapter #280
Conversation
Codecov ReportBase: 98.88% // Head: 98.88% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #280 +/- ##
=======================================
Coverage 98.88% 98.88%
=======================================
Files 56 56
Lines 2325 2328 +3
=======================================
+ Hits 2299 2302 +3
Misses 26 26
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about the methods stop_resource
and terminate_resource
in the lancium adaper? Is there the conversion also necessary?
Good point. I think it does not matter here, but it does not harm anyway. So, I have fixed it as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work. It looks good to me. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @giffels, looks good!
Job id's at Lancium are integers and the Lancium adapter is treating them also as integers. In addition, the job id is used as
remote_resource_uuid
inTARDIS
and is therefore stored in the persistent drone registry.In the drone registry the
remote_resource_uuid
is handled asVARCHAR(255)
. Thus. whenTARDIS
is restarted after a shutdown, theremote_resource_uuid
is treated as a string in TARDIS.This pull request fixes the handling of jobd ids in the Lancium adapter by always converting the
remote_resource_uuid
to an integer before actually checking the status of the corresponding job in Lancium.