Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin pyauditor to version to 0.0.6 #285

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

giffels
Copy link
Member

@giffels giffels commented Feb 16, 2023

Due to #283 I have pinned the pyauditor version to 0.0.6 for the time being, until the Auditor plugin has been fixed.

@giffels giffels requested review from a team, maxfischer2781 and rfvc and removed request for a team February 16, 2023 08:24
@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2023

Codecov Report

Base: 98.88% // Head: 98.88% // No change to project coverage 👍

Coverage data is based on head (1a83ffd) compared to base (d6ee17d).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #285   +/-   ##
=======================================
  Coverage   98.88%   98.88%           
=======================================
  Files          56       56           
  Lines        2328     2328           
=======================================
  Hits         2302     2302           
  Misses         26       26           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@stefan-k
Copy link
Contributor

Thanks! Sorry that I wasn't able to fix it until now. Due to other issues I'll have to postpone this to next week. From now on I'll pin to the exact version until we have a non-zero minor version and can actually make semver-compatible guarantees regarding the API.

maxfischer2781
maxfischer2781 previously approved these changes Feb 16, 2023
Copy link
Member

@maxfischer2781 maxfischer2781 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a fan of pinning or upper-bounding (see here for a nicer writeup than I could do) – but this seems to be the practical approach here for now until the API is stable. Thanks @stefan-k for weighing in with developer background!

Copy link

@RHofsaess RHofsaess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@giffels giffels added this pull request to the merge queue Feb 16, 2023
Merged via the queue into MatterMiners:master with commit 0afdc0a Feb 16, 2023
@giffels giffels deleted the pin-pyauditor-version branch February 16, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants