Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing B028 flake warnings #289

Merged
merged 1 commit into from
Feb 23, 2023
Merged

Conversation

giffels
Copy link
Member

@giffels giffels commented Feb 23, 2023

This pull request applies changes to make flake liniting happy again, we now use stacklevel=2 on warnings as suggested by flake.

@giffels giffels added the Improvement Code Improvements label Feb 23, 2023
@giffels giffels requested review from a team, mschnepf and RHofsaess and removed request for a team February 23, 2023 09:51
@mschnepf
Copy link
Member

Looks fine 👍

Copy link

@RHofsaess RHofsaess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@giffels giffels added this pull request to the merge queue Feb 23, 2023
Merged via the queue into MatterMiners:master with commit 61f6f54 Feb 23, 2023
@giffels giffels deleted the fix/fix-flake-B028 branch February 27, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Code Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants