AUDITOR plugin: fix for config without components #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giffels
requested review from
a team,
giffels and
mschnepf
and removed request for
a team
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #290 +/- ##
=======================================
Coverage 98.80% 98.80%
=======================================
Files 56 56
Lines 2339 2342 +3
=======================================
+ Hits 2311 2314 +3
Misses 28 28
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
mschnepf
approved these changes
Mar 9, 2023
giffels
approved these changes
Mar 14, 2023
giffels
added a commit
to giffels/tardis
that referenced
this pull request
Apr 4, 2023
giffels
added a commit
to giffels/tardis
that referenced
this pull request
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AUDITOR plugin currently crashes when no components are defined in the config, despite being marked as "optional" in the documentation.
This PR fixes this by simply continuing in such cases.