Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pydantic version 1 #298

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

giffels
Copy link
Member

@giffels giffels commented Jul 17, 2023

TARDIS is only compatible with pydantic version 1. Since the default is now version 2.0.3, I would like to pin the use of version 1 in setup.py.

@giffels giffels marked this pull request as ready for review July 17, 2023 10:53
@giffels giffels requested review from a team, maxfischer2781 and eileen-kuehn and removed request for a team July 17, 2023 10:54
giffels added a commit to giffels/tardis that referenced this pull request Jul 17, 2023
Copy link
Member

@maxfischer2781 maxfischer2781 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pin it!

Copy link
Member

@eileen-kuehn eileen-kuehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go for it! 🚀

@giffels giffels added this pull request to the merge queue Jul 17, 2023
Merged via the queue into MatterMiners:master with commit 35bfe17 Jul 17, 2023
@giffels giffels deleted the fix/pin-pydantic-version branch July 17, 2023 11:34
giffels added a commit to giffels/tardis that referenced this pull request Jul 17, 2023
@giffels giffels mentioned this pull request Aug 8, 2023
10 tasks
giffels added a commit to giffels/tardis that referenced this pull request Aug 8, 2023
giffels added a commit to giffels/tardis that referenced this pull request Aug 10, 2023
giffels added a commit to giffels/tardis that referenced this pull request Aug 15, 2023
giffels added a commit to giffels/tardis that referenced this pull request Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants