-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pyauditor to 0.2.0 #311
Update pyauditor to 0.2.0 #311
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! However, could you remove the pytz
package from setup.py
as well, please? It has been introduced in c2a1eb9
f747660
to
755c901
Compare
Done!
|
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #311 +/- ##
=======================================
Coverage 98.90% 98.90%
=======================================
Files 55 55
Lines 2277 2277
=======================================
Hits 2252 2252
Misses 25 25
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
● Signs point to yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks a lot for your contribution.
With the release of Auditor v0.2.0, we also must update the Auditor plugin in tardis. As discussed in #306 Auditor should return an error 404 instead of 400 when a non-existing record is updated. This change is included in v0.2.0, which means that we also need to adjust the error handling here.
Furthermore, due to an update in an upstream library, we also need to change the way we create DateTime objects. However, creating records the old way with the old version of pyauditor still works when the new version is used for the Auditor server instance. For more details, see the Migration guide.