Fix hash credentials test for new typer version #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giffels
requested review from
a team,
maxfischer2781 and
RHofsaess
and removed request for
a team
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #342 +/- ##
==========================================
+ Coverage 98.87% 98.92% +0.04%
==========================================
Files 55 55
Lines 2225 2226 +1
==========================================
+ Hits 2200 2202 +2
+ Misses 25 24 -1 ☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
maxfischer2781
approved these changes
Apr 16, 2024
RHofsaess
approved these changes
Apr 25, 2024
There was a problem hiding this comment.
Is it intended to add Sebastian twice?
There was a problem hiding this comment.
Okay, Matthias is there also two times, so probably nvm? :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a new typer version one of the
hash_credentialsunittest was broken, which is fixed in this pull request.