Updated ACME grammar from GoDot #11
Conversation
grammars/acme.cson
Outdated
| name: 'keyword.operator.acme' | ||
| } | ||
| # Operators II | ||
| # Operators (don't work) |
There was a problem hiding this comment.
What is the trouble with this? When I uncomment it, it works fine, as do Operators II.
Have you checked if your syntax theme in Atom highlights operators? I found that some syntax themes simply do not highlight certain scopes. I had that problem when writing a grammar for 6809 assembly, my grammar code was correct but my syntax theme simply didn't include code for highlighting certain scopes. Switching between several syntax themes sometimes reveals that problem.
EDIT: I use Monokai Seti as syntax theme
There was a problem hiding this comment.
I hadn't tried, I will uncomment them.
grammars/acme.cson
Outdated
| @@ -33,74 +33,99 @@ repository: | |||
| # symbols | |||
| symbols: | |||
| patterns: [ | |||
| # Labels (at beginning of a line) | |||
| { | |||
| match: '^[A-Za-z][A-Za-z0-9_:]*' | |||
There was a problem hiding this comment.
I suggest changing this to
match: '^[A-Za-z\\._][A-Za-z0-9_:]*'
Global labels can start with a underscore, local labels with a colon.
There was a problem hiding this comment.
Thanks, updated! I'm just doing this PR on GoDot's behalf.
MatthewCallis
force-pushed
the
ACME-UPDATES
branch
3 times, most recently
from
9bdc001 to
dc9362e
Compare
|
I fixed the items you pointed out, I trusted that GoDot had tested this but the syntax highlighting issue makes sense, thank you! |
MatthewCallis
force-pushed
the
ACME-UPDATES
branch
from
dc9362e to
b4a88e0
Compare
No description provided.