eclipse-glsp#153: Improve external navigation support through dedicat…

…ed action (eclipse-glsp#92)

- Introduce dedicated 'NavigateToExternalTarget' action
- Fix issue with wrong field name in 'NavigateToTarget' action

Part of eclipse-glsp/glsp/issues/153

Signed-off-by: Martin Fleck <mfleck@eclipsesource.com>

plugins/org.eclipse.glsp.server/src/org/eclipse/glsp/server/features/navigation/NavigateToExternalTargetAction.java

@@ -0,0 +1,38 @@
+/********************************************************************************
+ * Copyright (c) 2020 EclipseSource and others.
+ *
+ * This program and the accompanying materials are made available under the
+ * terms of the Eclipse Public License v. 2.0 which is available at
+ * https://www.eclipse.org/legal/epl-2.0.
+ *
+ * This Source Code may also be made available under the following Secondary
+ * Licenses when the conditions for such availability set forth in the Eclipse
+ * Public License v. 2.0 are satisfied: GNU General Public License, version 2
+ * with the GNU Classpath Exception which is available at
+ * https://www.gnu.org/software/classpath/license.html.
+ *
+ * SPDX-License-Identifier: EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0
+ ********************************************************************************/
+package org.eclipse.glsp.server.features.navigation;
+
+import org.eclipse.glsp.server.actions.Action;
+
+public class NavigateToExternalTargetAction extends Action {
+
+   public static final String ID = "navigateToExternalTarget";
+
+   private NavigationTarget target;
+
+   public NavigateToExternalTargetAction() {
+      super(ID);
+   }
+
+   public NavigateToExternalTargetAction(final NavigationTarget target) {
+      this();
+      this.target = target;
+   }
+
+   public NavigationTarget getTarget() { return target; }
+
+   public void setTarget(final NavigationTarget navigationTarget) { this.target = navigationTarget; }
+}

plugins/org.eclipse.glsp.server/src/org/eclipse/glsp/server/features/navigation/NavigateToTargetAction.java

@@ -21,20 +21,20 @@ public class NavigateToTargetAction extends Action {
 
    public static final String ID = "navigateToTarget";
 
-   private NavigationTarget navigationTarget;
+   private NavigationTarget target;
 
    public NavigateToTargetAction() {
       super(ID);
    }
 
-   public NavigateToTargetAction(final NavigationTarget navigationTarget) {
+   public NavigateToTargetAction(final NavigationTarget target) {
       this();
-      this.navigationTarget = navigationTarget;
+      this.target = target;
    }
 
-   public NavigationTarget getNavigationTarget() { return navigationTarget; }
+   public NavigationTarget getTarget() { return target; }
 
-   public void setNavigationTarget(final NavigationTarget navigationTarget) {
-      this.navigationTarget = navigationTarget;
+   public void setTarget(final NavigationTarget navigationTarget) {
+      this.target = navigationTarget;
    }
 }

plugins/org.eclipse.glsp.server/src/org/eclipse/glsp/server/internal/di/MultiBindingDefaults.java

@@ -53,6 +53,7 @@
 import org.eclipse.glsp.server.features.directediting.RequestEditValidationHandler;
 import org.eclipse.glsp.server.features.directediting.SetEditValidationResultAction;
 import org.eclipse.glsp.server.features.modelsourcewatcher.ModelSourceChangedAction;
+import org.eclipse.glsp.server.features.navigation.NavigateToExternalTargetAction;
 import org.eclipse.glsp.server.features.navigation.NavigateToTargetAction;
 import org.eclipse.glsp.server.features.navigation.RequestNavigationTargetsActionHandler;
 import org.eclipse.glsp.server.features.navigation.ResolveNavigationTargetActionHandler;
@@ -108,6 +109,7 @@ private MultiBindingDefaults() {}
       GLSPServerStatusAction.class,
       ModelSourceChangedAction.class,
       NavigateToTargetAction.class,
+      NavigateToExternalTargetAction.class,
       RequestBoundsAction.class,
       SelectAction.class,
       SelectAllAction.class,