Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Twoslash) Bug: Default style settings reference Astro Starlight theme tokens #30

Closed
IMax153 opened this issue Dec 5, 2024 · 1 comment · Fixed by #35
Closed

(Twoslash) Bug: Default style settings reference Astro Starlight theme tokens #30

IMax153 opened this issue Dec 5, 2024 · 1 comment · Fixed by #35
Labels
bug Something isn't working twoslash expressive-code-twoslash

Comments

@IMax153
Copy link
Contributor

IMax153 commented Dec 5, 2024

Describe the bug

In the styles.ts, there is a reference to an Astro Starlight theme token:

color: var(--sl-color-white) !important;

This variable is unset in projects that may use expressive-code-twoslash but not Astro Starlight.

To Reproduce

Steps to reproduce the behavior:

  1. Open the styles.ts file and scroll to line 398.

Expected behavior

This design token should be set to something valid and configurable, preferably with the same behavior as the Starlight token, which switches between plain white and plain black depending on the theme.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@IMax153 IMax153 added bug Something isn't working twoslash expressive-code-twoslash labels Dec 5, 2024
@Adammatthiesen
Copy link
Member

Dang it... i thought i got rid of all those 😅 (that was for testing purposes before i had gotten most if not all the custom styles in place) will start working on it soon!

Adammatthiesen added a commit that referenced this issue Dec 16, 2024
@Adammatthiesen Adammatthiesen mentioned this issue Dec 16, 2024
Adammatthiesen added a commit that referenced this issue Dec 16, 2024
* fix #30

* fixes #31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working twoslash expressive-code-twoslash
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants