Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Twoslash popup docs use configured code font-family for inline code #32

Merged
merged 3 commits into from
Dec 16, 2024

Conversation

IMax153
Copy link
Contributor

@IMax153 IMax153 commented Dec 5, 2024

Description

Apologies for the large number of changes in this PR - I wasn't expecting pnpm lint:fix to "fix" so many things 😅.

The main change being made here (aside from the formatting introduced by biome) is to ensure that inline code tags use the configured codeFontFamily. The CSS that's been added is as follows:

        .twoslash-popup-docs code {
            font-family: ${cssVar("codeFontFamily")};
            font-weight: ${cssVar("codeFontWeight")};
        }

See lines 351-355 in the diff.

Copy link

changeset-bot bot commented Dec 5, 2024

🦋 Changeset detected

Latest commit: 04e2ef1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
expressive-code-twoslash Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Dec 16, 2024

Open in Stackblitz

npm i https://pkg.pr.new/expressive-code-twoslash@32

commit: 04e2ef1

@Adammatthiesen
Copy link
Member

Sorry for the delay, manged to miss your PR and issues till now, been working on StudioCMS and all the chaos of starting that CMS project 😅 looking into your PR and issues now!

Copy link

netlify bot commented Dec 16, 2024

Deploy Preview for expressive-code-twoslash ready!

Name Link
🔨 Latest commit 04e2ef1
🔍 Latest deploy log https://app.netlify.com/sites/expressive-code-twoslash/deploys/675fb7760de08700086a9d28
😎 Deploy Preview https://deploy-preview-32--expressive-code-twoslash.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Adammatthiesen Adammatthiesen merged commit b094bb2 into MatthiesenXYZ:main Dec 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants