chore: handle LOAD_METHOD opcode in CPython 3.12 #129
Conversation
| if isinstance(arg, str): | ||
| # Assume the bitflag is not set | ||
| arg = (False, arg) |
There was a problem hiding this comment.
This is a breaking change from what currently documented
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #129 +/- ##
==========================================
- Coverage 95.60% 95.51% -0.09%
==========================================
Files 6 6
Lines 2000 2005 +5
Branches 481 484 +3
==========================================
+ Hits 1912 1915 +3
- Misses 53 54 +1
- Partials 35 36 +1
☔ View full report in Codecov by Sentry. |
Allow handling the `LOAD_METHOD` pseudo-instruction in CPython 3.12 by converting it to the equivalent `LOAD_ATTR` instruction.
P403n1x87
force-pushed
the
chore/handle-load-method
branch
from
51297f0 to
bdc6775
Compare
| @@ -1143,6 +1143,17 @@ def concrete_instructions(self) -> None: | |||
| free_instrs: List[int] = [] | |||
|
|
|||
| for instr in self.bytecode: | |||
| if sys.version_info >= (3, 12) and isinstance(instr, Instr): | |||
| if instr.name == "LOAD_METHOD": | |||
There was a problem hiding this comment.
Would there be a better place to handle these sorts of transformations? Just thinking of ways of keeping this tidy in case of future similar changes.
|
I am extremely hesitant to allow this kind of things. In particular I fear that "legalizing" the bytecode when converting to concrete may be too late since we need a CFG to compute the stack size and I would not bet on dis.stack_effect being accurate for pseudo instructions. This and your request about TryBegin/End to me sound more like we could have a more abstract builder for bytecode that we could then safely compile before doing any computation on it. Food for though. |
|
I've had this idea for a while now and finally had a chance to experiment with it https://github.com/P403n1x87/spasmlang. Perhaps these sorts of transformations can be handled at this higher level. |
|
I'm closing this PR since my use cases are now covered by P403n1x87/spasmlang#2. |
Allow handling the
LOAD_METHODpseudo-instruction in CPython 3.12 by converting it to the equivalentLOAD_ATTRinstruction.Resolves #128.