fix: handle small try blocks #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #145 +/- ##
==========================================
+ Coverage 95.53% 95.63% +0.10%
==========================================
Files 6 6
Lines 1970 1971 +1
Branches 474 475 +1
==========================================
+ Hits 1882 1885 +3
+ Misses 53 52 -1
+ Partials 35 34 -1 ☔ View full report in Codecov by Sentry. |
We make sure that we can handle small (and potentially empty) try blocks. These are blocks where the end offset is smaller or at most equal to the start offset. These blocks can occur when a single instruction that requires EXTENDED_ARG opcodes is wrapped in a try block. Original code objects seem to wrap the whole instruction, including the EXTENDED_ARG opcodes. The fix in this PR wraps just the instruction, leaving the extra EXTENDED_ARG opcodes outside the try block. This might not be a problem in general, but it is perhaps not ideal.
P403n1x87
force-pushed
the
fix/small-try-block
branch
from
3820a5c to
598fdea
Compare
MatthieuDartiailh
requested changes
May 27, 2024
MatthieuDartiailh
approved these changes
May 28, 2024
This was referenced Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We make sure that we can handle small (and potentially empty) try blocks. These are blocks where the end offset is smaller or at most equal to the start offset. These blocks can occur when a single instruction that requires EXTENDED_ARG opcodes is wrapped in a try block. Original code objects seem to wrap the whole instruction, including the EXTENDED_ARG opcodes. The fix in this PR wraps just the instruction, leaving the extra EXTENDED_ARG opcodes outside the try block. This might not be a problem in general, but it is perhaps not ideal.
Addresses #144.