Ci/improve code collection #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We improve the logic for round-trip re-compilation of code objects by listening for module code objects before they are executed. This way we can thoroughly recurse over nested code object and attain total coverage for better confidence.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #149 +/- ##
==========================================
- Coverage 95.79% 95.79% -0.01%
==========================================
Files 7 7
Lines 2044 2043 -1
Branches 464 464
==========================================
- Hits 1958 1957 -1
Misses 52 52
Partials 34 34 ☔ View full report in Codecov by Sentry. |
MatthieuDartiailh
force-pushed
the
ci/improve-code-collection
branch
2 times, most recently
from
b18a1c6 to
1c801c0
Compare
This is necessary because the TryEnd may be relevant only in some particular branching conditions.
MatthieuDartiailh
force-pushed
the
ci/improve-code-collection
branch
from
1c801c0 to
95c3de4
Compare
MatthieuDartiailh
force-pushed
the
ci/improve-code-collection
branch
from
0d3b31e to
d4c217c
Compare
|
@P403n1x87 I pulled your work #143 and after investigating a bit more the 3.11 failure came up with a marginally different solution (mostly a clearer explanation of why things happen). If you are fine with it I will merge and then proceed to 0.16.0 release with Python 3.13 support. |
P403n1x87
approved these changes
Oct 27, 2024
This was referenced Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.