forked from web-platform-tests/wpt
-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix flaky test memory leak (web-platform-tests#34723)
event-timing-test-utils.js tap() has some unknown flaky memory leak issue related to test_driver.Actions(), while test_driver also has a built in function for click which doesn't cause any memory leak. This commit replace tap with click to fix the memory leak and re-enable the disabled test. Test coverage for tap will be added later once Bug 1338420 is fixed. Also added helper function addListenersAndClick() to reduce repetitive patterns between tests. Bug: 1335002 Change-Id: Ic2670288e596ff5eac8f1e742e395717bdabde5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3747288 Reviewed-by: Lan Wei <lanwei@chromium.org> Commit-Queue: Aoyuan Zuo <zuoaoyuan@chromium.org> Reviewed-by: Michal Mocny <mmocny@chromium.org> Cr-Commit-Position: refs/heads/main@{#1021762} Co-authored-by: Aoyuan Zuo <zuoaoyuan@chromium.org>
- Loading branch information
Showing
3 changed files
with
13 additions
and
19 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters