Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frontmatter reviewer does not filter/skip attempting to assign the same user as PR owner which results in error #32

Closed
Matticusau opened this issue Jul 31, 2020 · 1 comment
Closed

Frontmatter reviewer does not filter/skip attempting to assign the same user as PR owner which results in error #32

Matticusau opened this issue Jul 31, 2020 · 1 comment
Assignees
@Matticusau
Labels
bug Something isn't working

Comments

@Matticusau
Copy link
Owner

Matticusau commented Jul 31, 2020 •
edited
Loading

Bug Report

Current Behavior
When using front-matter reviewer requests, the logic may try and request a review from the person who raised the PR.

CODEOWNERs is not impacted by this as GitHub handles that internally.

To Reproduce
Steps to reproduce the behavior:

  1. Add a file with frontmatter referencing your username as the owner (configure the appropriate settings for the key value)
  2. Create a PR that edits that file
  3. The workflow will fail as it tries to assign you as the reviewer
  4. See error

Expected behavior/code
A check should be added to avoid adding the PR owner as the reviewer

Environment

  • version(s): v1.2.1

Additional context/Screenshots
Add any other context about the problem here. If applicable, add screenshots to help explain.

image
@Matticusau Matticusau added bug Something isn't working needs triage New issues which need to be triaged labels Jul 31, 2020
@Matticusau Matticusau self-assigned this Jul 31, 2020
@Matticusau Matticusau added under investigation and removed needs triage New issues which need to be triaged labels Jul 31, 2020
Matticusau added a commit that referenced this issue Jul 31, 2020
@Matticusau
PR author not reviewer #32
0f7501d
Matticusau added a commit that referenced this issue Aug 1, 2020
@Matticusau
Fixes #32
84da7db
@Matticusau Matticusau mentioned this issue Aug 1, 2020
Merged
Matticusau added a commit that referenced this issue Aug 1, 2020
@Matticusau
Fixes for Frontmatter reviewer does not filter/skip attempting to ass…
07854c7 
…ign the same user as PR owner which results in error #32 (#33)

* Fixes frontmatter reviewer does not filter/skip attempting to assign the same user as PR owner which results in error #32
@Matticusau
Copy link
Owner Author

Matticusau commented Aug 1, 2020 •
edited
Loading

Released in v1.2.2

Matticusau added a commit that referenced this issue Jun 14, 2021
@Matticusau
Release v1.3.0 (#51)
7049571 
* suggested label colors

* Fixes require zero requested changes #16

* Fixes #17

* Auto Merge Filter feature (#18)

* Initial filtering support #15

* Added glob processing #15

* logging

* json pattern conversion

* lets just expect the json object

* logging

* Removed need to match ALL globs

* removed some logging

* Updated docs for #15

* Improve class constructors efficiency

* Reviewer patch 1 (#20)

* Retrieves the raw file data

* Extracts the custom key from the YAML front matter

* Adds reviewers to a pull request from any modified file

* YAML front matter is taken from the Pull Requests base, not the pull request to ensure people cannot overwrite this value

* supports enable/disable and custom key

* Added delete branch functionality #14

* Skip new files #19

* added branch delete deny #14

* config spelling

* branch head ref

* logging clean up

* Docs and renamed config value

* Label handler ondemand /  onschedule #24

* logging

* logging

* logging

* logging

* added ondemand onschedule for label handler Action not running on PRs from Forked repos #24

* Logic changes for ondemand vs onschedule #24

* review on schedule #24 & intitial author yaml #23

* added length check #23

* Jekyll author file lookup #23

* Added action params

* corrected prreviewer-authorfilepath param #23

* logging

* added ref param

* logging

* Hanlding of empty author key

* extra check for github username

* get raw author file

* logging

* path update

* logging

* loggin

* logging

* removed check for author object length

* removing debug logging

* review on schedule

* Feature preview of #23 and #24

* docs update

* docs - link to issue in known issue

* Added check for auto merge label #28

* Initial fix for undefined author #30

* logging

* logging

* frontmatter attributes test logic

* testing frontmatter.attributes

* clean up

* PR author not reviewer #32

* Testing PR Author review

* Testing the PR Author vs Reviewer

* Extra logging

* force login check to lowercase

* Fixes #32

* Support for #37 #35 #15

* Only support modified files for now #35

* Extending handling of Not Found error #35

* fix addLabel and API efficiency #41

* initial logic for owner review bypass #36

* docs #36

* action config

* debug info

* debug info

* logic improvement

* debug info

* updated docs

* change log

* fixing node-notifier dependabot update

* debug info for checks test

* workflow_run support #50

* 1.3.0

* release instructions

* Releasing v1.3.0
Matticusau added a commit that referenced this issue May 18, 2022
@Matticusau
Dev (#60)
3843ffe 
* suggested label colors

* Fixes require zero requested changes #16

* Fixes #17

* Auto Merge Filter feature (#18)

* Initial filtering support #15

* Added glob processing #15

* logging

* json pattern conversion

* lets just expect the json object

* logging

* Removed need to match ALL globs

* removed some logging

* Updated docs for #15

* Improve class constructors efficiency

* Reviewer patch 1 (#20)

* Retrieves the raw file data

* Extracts the custom key from the YAML front matter

* Adds reviewers to a pull request from any modified file

* YAML front matter is taken from the Pull Requests base, not the pull request to ensure people cannot overwrite this value

* supports enable/disable and custom key

* Added delete branch functionality #14

* Skip new files #19

* added branch delete deny #14

* config spelling

* branch head ref

* logging clean up

* Docs and renamed config value

* Label handler ondemand /  onschedule #24

* logging

* logging

* logging

* logging

* added ondemand onschedule for label handler Action not running on PRs from Forked repos #24

* Logic changes for ondemand vs onschedule #24

* review on schedule #24 & intitial author yaml #23

* added length check #23

* Jekyll author file lookup #23

* Added action params

* corrected prreviewer-authorfilepath param #23

* logging

* added ref param

* logging

* Hanlding of empty author key

* extra check for github username

* get raw author file

* logging

* path update

* logging

* loggin

* logging

* removed check for author object length

* removing debug logging

* review on schedule

* Feature preview of #23 and #24

* docs update

* docs - link to issue in known issue

* Added check for auto merge label #28

* Initial fix for undefined author #30

* logging

* logging

* frontmatter attributes test logic

* testing frontmatter.attributes

* clean up

* PR author not reviewer #32

* Testing PR Author review

* Testing the PR Author vs Reviewer

* Extra logging

* force login check to lowercase

* Fixes #32

* Support for #37 #35 #15

* Only support modified files for now #35

* Extending handling of Not Found error #35

* fix addLabel and API efficiency #41

* initial logic for owner review bypass #36

* docs #36

* action config

* debug info

* debug info

* logic improvement

* debug info

* updated docs

* change log

* fixing node-notifier dependabot update

* debug info for checks test

* workflow_run support #50

* 1.3.0

* release instructions

* Releasing v1.3.0

* reviewer error handling #55

* 1.3.1

* update typescript

* preparing release

* troubleshooting #59

* 1.3.2

* release v1.3.2

* release notes

* extra error logging

* 1.3.3

* v1.3.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Matticusau Matticusau

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Matticusau