Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/gh 5 #7

Merged
merged 6 commits into from
Dec 13, 2021
Merged

Feature/gh 5 #7

merged 6 commits into from
Dec 13, 2021

Conversation

aaronforshaw
Copy link
Contributor

Closes #5

This change:

  • adds tests of enumeration detection on empty strings. (The actual fix for handling empty strings was done in a previous change to mdm-plugin-database gh-9 Skip empty strings '' for enumerations. Save summary metadata to… mdm-plugin-database#10)
  • adds a test that summary metadata is saved to the data class as well as data element (the actual save is done in the above mentioned PR to mdm-plugin-database)
  • adds nchar and nvarchar to the column data types which trigger enumeration detection

@olliefreeman olliefreeman merged commit c62bdf1 into develop Dec 13, 2021
@olliefreeman olliefreeman deleted the feature/gh-5 branch December 13, 2021 11:22
joe-crawford pushed a commit that referenced this pull request Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error on Enumeration guessing where NULL values are present?
2 participants