Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide an endpoint to return a single ProfileProviderService #401

Closed
pjmonks opened this issue Mar 10, 2023 · 0 comments · Fixed by #402
Closed

Provide an endpoint to return a single ProfileProviderService #401

pjmonks opened this issue Mar 10, 2023 · 0 comments · Fixed by #402
Assignees
Labels
enhancement New feature or request

Comments

@pjmonks
Copy link
Contributor

pjmonks commented Mar 10, 2023

Description

There are two additions to mdm-plugin-profile that I think would be beneficial. This will help with metadata search.

Get single Profile Provider Service

There is currently only an endpoint to return a list of ProfileProviderService objects:

GET /profiles/providers

However, there is no endpoint to get a single ProfileProviderService. This should be added:

GET /profiles/providers/{profileNamespace}/{profileName}/{profileVersion?}

Where:

  1. profileNamespace and profileName are mandatory, profileVersion is optional
  2. Should return a single instance of the requested ProfileProviderService

This would then align with other REST endpoints by providing both an index and show controller action for providers.

List profile provider services by latest version

The GET /profiles/providers endpoint will always return every ProfileProviderService, including multiple version, since latestVersionByMetadataNamespace is hardcoded to be false. latestVersionByMetadataNamespace should be provided as an optional query parameter to allow the caller to decide this.

@pjmonks pjmonks added the enhancement New feature or request label Mar 10, 2023
@pjmonks pjmonks self-assigned this Mar 10, 2023
@github-project-automation github-project-automation bot moved this to Backlog in MDM State Mar 10, 2023
@pjmonks pjmonks moved this from Backlog to In Progress in MDM State Mar 10, 2023
pjmonks added a commit that referenced this issue Mar 13, 2023
- Also give profile providers index optional parameter to only return latest versions
- Add tests to verify new endpoint
@pjmonks pjmonks moved this from In Progress to Open PR in MDM State Mar 13, 2023
joe-crawford added a commit that referenced this issue Mar 14, 2023
gh-401 Create endpoint to return single ProfileProviderService
@github-project-automation github-project-automation bot moved this from Open PR to Merged to Develop / Waiting to release in MDM State Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Merged to Develop / Waiting to release
Development

Successfully merging a pull request may close this issue.

1 participant