Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/MC-9483 Add UI ability to see and handle importing and extending in DataModels #31

Merged
merged 14 commits into from
Aug 18, 2021

Conversation

atpw25
Copy link
Collaborator

@atpw25 atpw25 commented Aug 16, 2021

This is the API client side of MC-9483.

Copy link
Contributor

@pjmonks pjmonks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like what is here so far. One thing that would be useful are doc comments I feel - particularly explaining what the data returned for these endpoint calls are. While the TypeScript any type has to be used for all return types, I've found describing what actually gets returned is helpful for the client application to understand.

If these endpoints return existing defined type definitions, then these should be documented. Or if they are not defined yet then please do so. You'll find examples of this dotted around the resource files already.

Copy link
Contributor

@pjmonks pjmonks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great doc comments, they will help with the TypeDoc generation and IntelliSense using the node package in mdm-ui. Thanks.

@pjmonks pjmonks merged commit 5188909 into develop Aug 18, 2021
@pjmonks pjmonks deleted the feature/MC-9483 branch August 18, 2021 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants