-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/MC-9483 Add UI ability to see and handle importing and extending in DataModels #31
Conversation
# Conflicts: # lib/es2015/mdm-data-model.resource.js.map # lib/es5/mdm-data-model.resource.js.map
# Conflicts: # lib/es2015/mdm-data-model.resource.js.map # lib/es5/mdm-data-model.resource.js.map
# Conflicts: # lib/es2015/index.js.map # lib/es2015/mdm-data-model.resource.js.map # lib/es5/index.js.map # lib/es5/mdm-data-model.resource.js.map
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like what is here so far. One thing that would be useful are doc comments I feel - particularly explaining what the data returned for these endpoint calls are. While the TypeScript any
type has to be used for all return types, I've found describing what actually gets returned is helpful for the client application to understand.
If these endpoints return existing defined type definitions, then these should be documented. Or if they are not defined yet then please do so. You'll find examples of this dotted around the resource files already.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great doc comments, they will help with the TypeDoc generation and IntelliSense using the node package in mdm-ui
. Thanks.
This is the API client side of MC-9483.