Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix remaining Sonarqube major bugs identified #518

Closed
pjmonks opened this issue Apr 29, 2022 · 0 comments · Fixed by #613
Closed

Fix remaining Sonarqube major bugs identified #518

pjmonks opened this issue Apr 29, 2022 · 0 comments · Fixed by #613
Assignees
@OButlerOcc
Labels
clean up Consolidation after new features, refactoring, remove redundant code etc maintenance General maintenance on this repo or application
Milestone
7.2.0

Comments

@pjmonks
Copy link
Contributor

pjmonks commented Apr 29, 2022 •
edited
Loading

The Sonarqube report for mdm-ui can be found here: https://jenkins.cs.ox.ac.uk/sonarqube/project/issues?id=mdm-ui&resolved=false&severities=MAJOR&types=BUG

This shows there are (at the time of writing) 7 major bugs remaining:

  • The ones for rule "Remove this conditional structure or edit its code blocks so that they're not all the same." are actually tied to issue Remove legacy branch merge UI components #515 so once that is completed these will disappear
  • The others should be easily fixable

Removing these final major issues will upgrade the Sonarqube reliability grade from a C to higher.
@pjmonks pjmonks added clean up Consolidation after new features, refactoring, remove redundant code etc maintenance General maintenance on this repo or application labels Apr 29, 2022
@OButlerOcc OButlerOcc self-assigned this Jul 19, 2022
@pjmonks pjmonks linked a pull request Jul 22, 2022 that will close this issue
Feature/gh 518 sonarqube #613
Merged
pjmonks added a commit that referenced this issue Jul 22, 2022
@pjmonks
gh-518 Add scope attribute to th elements
1ca0d89
pjmonks added a commit that referenced this issue Jul 22, 2022
@pjmonks
gh-518 Temp allowance of Sonarqube run on branch build
d4d52ff
pjmonks added a commit that referenced this issue Jul 22, 2022
@pjmonks
gh-518 Add captions to HTML tables
d62c739
pjmonks added a commit that referenced this issue Jul 22, 2022
@pjmonks
gh-518 Revert Jenkinsfile back to normal
f90ec73
pjmonks added a commit that referenced this issue Jul 22, 2022
@pjmonks
Merge pull request #613 from MauroDataMapper/feature/gh-518-sonarqube
8d934fb 
Feature/gh 518 sonarqube
Repository owner moved this from Backlog to Merged to Develop / Waiting to release in MDM State Jul 22, 2022
@pjmonks pjmonks added this to the 7.2.0 milestone Jul 22, 2022
@joe-crawford joe-crawford moved this from Merged to Develop / Waiting to release to Released in MDM State Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OButlerOcc OButlerOcc

Labels
clean up Consolidation after new features, refactoring, remove redundant code etc maintenance General maintenance on this repo or application
Projects
MDM State
Status: Released
Milestone
7.2.0
Development

Successfully merging a pull request may close this issue.

Feature/gh 518 sonarqube MauroDataMapper/mdm-ui
2 participants
@pjmonks @OButlerOcc