Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removal of ngx-text-diff package #550

Closed
pjmonks opened this issue May 27, 2022 · 0 comments · Fixed by #551
Closed

Removal of ngx-text-diff package #550

pjmonks opened this issue May 27, 2022 · 0 comments · Fixed by #551
Assignees
@pjmonks
Labels
bug Something isn't working maintenance General maintenance on this repo or application
Milestone
7.2.0

Comments

@pjmonks
Copy link
Contributor

pjmonks commented May 27, 2022

The Renovate pull requests have found an artefact issue with package-lock.json:

npm ERR! code EINVALIDTAGNAME
npm ERR! Invalid tag name "^>=6.0.0" of package "@angular/cdk@^>=6.0.0": Tags may not have any characters that encodeURIComponent encodes.

npm ERR! A complete log of this run can be found in:
npm ERR!     /tmp/renovate-cache/others/npm/_logs/2022-05-27T12_36_03_963Z-debug-0.log

This issue comes from the package ngx-text-diff because it has set its peer dependencies using a legacy syntax. This issue explains more: ABenassi87/ngx-text-diff#62

However, this package isn't actually used, so the simplest way to resolve this is to remove it from the package.json list completely.
@pjmonks pjmonks added bug Something isn't working maintenance General maintenance on this repo or application labels May 27, 2022
@pjmonks pjmonks self-assigned this May 27, 2022
@pjmonks pjmonks moved this to Backlog in MDM State May 27, 2022
@pjmonks pjmonks moved this from Backlog to In Progress in MDM State May 27, 2022
pjmonks added a commit that referenced this issue May 27, 2022
@pjmonks
gh-550 Remove ngx-text-diff package
52e3bff
@pjmonks pjmonks mentioned this issue May 27, 2022
Merged
@pjmonks pjmonks moved this from In Progress to Open PR in MDM State May 27, 2022
jamesrwelch added a commit that referenced this issue May 27, 2022
@jamesrwelch
Merge pull request #551 from MauroDataMapper/feature/gh-550
4d0c607 
gh-550 Remove ngx-text-diff package
Repository owner moved this from Open PR to Merged to Develop / Waiting to release in MDM State May 27, 2022
@pjmonks pjmonks added this to the 7.2.0 milestone May 27, 2022
@joe-crawford joe-crawford moved this from Merged to Develop / Waiting to release to Released in MDM State Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pjmonks pjmonks

Labels
bug Something isn't working maintenance General maintenance on this repo or application
Projects
MDM State
Status: Released
Milestone
7.2.0
Development

Successfully merging a pull request may close this issue.

gh-550 Remove ngx-text-diff package MauroDataMapper/mdm-ui
1 participant
@pjmonks