Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare data model functionality broken #556

Closed
jelenadreskai opened this issue Jun 6, 2022 · 3 comments · Fixed by #558
Closed

Compare data model functionality broken #556

jelenadreskai opened this issue Jun 6, 2022 · 3 comments · Fixed by #558
Assignees
Labels
bug Something isn't working
Milestone

Comments

@jelenadreskai
Copy link

Description

Cannot initiate Compare data model functionality

Steps to reproduce

  1. Login as and Administrator or Container Administrator (this may not work for other user types as well)
  2. Select data model in the tree structure, right click and select Compare to Another model
  3. Error is shown to the end user

Expected behavior

Compare UI shows up to the end user

Screenshots

image

Environment

  • Mauro UI [7.1.0]
  • mdm-core [5.1.0]

Additional context

Message Http failure response for http://localhost:8084/api/tree/dataModels/DataModel/c781822f-9b59-4e02-bbb5-cedc17a672d7: 400 OK
Status 400
Path http://localhost:8084/api/tree/dataModels/DataModel/c781822f-9b59-4e02-bbb5-cedc17a672d7

@jelenadreskai jelenadreskai added the bug Something isn't working label Jun 6, 2022
@GBishop-PHSA
Copy link
Contributor

@olliefreeman We're seeing in the logs that the TreeInterceptor fails because of the uncommented code that throws the exception. (mc-9800)

The request is:
[GET] /api/tree/dataModels/DataModel/
Where the model uuid is for a draft data model.

Is the UI supposed to be calling a different url to build the tree when using the compare function?

@olliefreeman
Copy link
Contributor

moving this to the ui, as the UI is using the wrong endpoint.
It should be

api/tree/$containerDomainType/$catalogueItemDomainType/$catalogueItemId

@olliefreeman olliefreeman transferred this issue from MauroDataMapper/mdm-core Jun 7, 2022
@olliefreeman olliefreeman moved this to Backlog in MDM State Jun 7, 2022
@olliefreeman olliefreeman moved this from Backlog to Fix for next release in MDM State Jun 7, 2022
@pjmonks pjmonks self-assigned this Jun 7, 2022
@pjmonks pjmonks moved this from Fix for next release to In Progress in MDM State Jun 7, 2022
pjmonks added a commit that referenced this issue Jun 7, 2022
* Use the correct endpoint for fetching the tree child nodes
* Tidy up existing code
@pjmonks pjmonks added this to the 7.2.0 milestone Jun 7, 2022
@pjmonks pjmonks moved this from In Progress to Open PR in MDM State Jun 7, 2022
@pjmonks
Copy link
Contributor

pjmonks commented Jun 8, 2022

The incorrect endpoint was indeed used, this has been fixed now.

pjmonks added a commit that referenced this issue Jun 8, 2022
gh-556 Fix model comparison screen not loading
Repository owner moved this from Open PR to Merged to Develop / Waiting to release in MDM State Jun 8, 2022
@joe-crawford joe-crawford moved this from Merged to Develop / Waiting to release to Released in MDM State Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Released
Development

Successfully merging a pull request may close this issue.

4 participants