Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show leave confirmation message at appropriate times in bulk editor #624

Closed
pjmonks opened this issue Jul 28, 2022 · 0 comments · Fixed by #797
Closed

Show leave confirmation message at appropriate times in bulk editor #624

pjmonks opened this issue Jul 28, 2022 · 0 comments · Fixed by #797
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@pjmonks
Copy link
Contributor

pjmonks commented Jul 28, 2022

Description

The current implementation of the bulk editor will always show a confirmation message if you choose to leave and navigate to a different page:

image

This confirmation logic could be improved by only showing if there are unsaved changes - it seems pointless showing the message if you have definitely saved all your current work. This would most likely require better tracking of edit changes made in each tab/spreadsheet.

@pjmonks pjmonks added the enhancement New feature or request label Jul 28, 2022
@pjmonks pjmonks moved this to Backlog in MDM State Jul 28, 2022
@pjmonks pjmonks moved this from Backlog to Fix for next release in MDM State Aug 16, 2022
@pjmonks pjmonks moved this from Fix for next release to Backlog in MDM State Nov 28, 2022
@pjmonks pjmonks self-assigned this Mar 20, 2023
@pjmonks pjmonks moved this from Backlog to In Progress in MDM State Mar 20, 2023
pjmonks added a commit that referenced this issue Mar 20, 2023
- Confirm switching panes or closing if values have changed but not been saved
- Also fixed bug with auto sizing columns due to wrong column key used
@pjmonks pjmonks moved this from In Progress to Open PR in MDM State Mar 20, 2023
@pjmonks pjmonks added this to the 7.4.0 milestone Mar 20, 2023
pjmonks added a commit that referenced this issue Mar 22, 2023
gh-624 Track changed state in bulk editor tabs
@github-project-automation github-project-automation bot moved this from Open PR to Merged to Develop / Waiting to release in MDM State Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Merged to Develop / Waiting to release
Development

Successfully merging a pull request may close this issue.

1 participant