Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Data Elements to another Data Class within the same model #869

Open
pjmonks opened this issue Jun 7, 2024 · 1 comment
Open

Move Data Elements to another Data Class within the same model #869

pjmonks opened this issue Jun 7, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@pjmonks
Copy link
Contributor

pjmonks commented Jun 7, 2024

Depends on

Description

There is a requirement from NHS England to be able to move Data Elements between Data Classes, so long as they are within the same Data Model (to not break existing links to data types etc).

Move Option

A new menu option called "Move..." should appear in the triple-dot menu for (only) a Data Element, here:

Image

This menu option should only appear if:

  • The current user is allowed to update items - governed by the update in avalableActions.
  • There is at least one other data class to move to - no point moving to itself.

Move To Dialog

Selecting the menu item should open a new dialog. Inside, this is where the user selects an existing data class within the same data model. Ideally, this should exclude the current data class the data element sits under.

Once selected, the user should be able to click a primary action button e.g. "Move", or cancel/close the dialog to do nothing.

Update Data Element

Finally, the standard Data Element update endpoint should be invoked:

PUT /api/dataModels/{modelId}/dataClasses/{classId}/dataElements/{elementId}

{
    "dataClass": "{anotherClassId}"
}

For this request, no other properties need to be updated, just the dataClass parent UUID.

Once successful, the page should refresh to reflect the change and a confirmation toast message should appear.

Related

@pjmonks pjmonks added the enhancement New feature or request label Jun 7, 2024
@OButlerOcc OButlerOcc self-assigned this Jun 20, 2024
@pjmonks pjmonks assigned pjmonks and unassigned OButlerOcc Jun 21, 2024
pjmonks added a commit that referenced this issue Jun 25, 2024
- Incomplete, need to better display list of possible data classes to transfer to
@pjmonks
Copy link
Contributor Author

pjmonks commented Jun 25, 2024

Now going to put this on hold. Technically this work is not in the statement of work agreed with NHS England and building this feature is taking up time - there may not even be a need for it depending on discussions of re-organising the dictionary structure in Mauro.

Parking for now, we may revisit the work and complete later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants