Added Filter for type #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesrwelch
reviewed
Oct 22, 2021
There was a problem hiding this comment.
This works, so happy to approve it. Two related issues:
- The message "There are no Data Types in this repository." should be changed - maybe to something like: "There are no Data Types in this model that match the applied filters" if a filter is set. The word "repository" should be changed to "model" either way.
- Sorting by type (with no filter applied) gives me a server error. I'm not sure this used to be the case - so maybe it can be fixed without a back-end update?
Do you want to add those fixes to this PR, or shall I raise new tickets and you can fix those separately?
|
Lets get a second Issue going on the sorting problem |
jamesrwelch
previously approved these changes
Oct 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.