Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MC-9802 Update tree control with endpoint updates #469

Merged
merged 1 commit into from
Feb 22, 2022

Conversation

pjmonks
Copy link
Contributor

@pjmonks pjmonks commented Feb 16, 2022

  • Folders returned for the tree root no longer auto-expand, so ensure that every container can be expanded on request
  • Send modelCreatableOnly param for the tree view in the import screens

Note: this PR can be converted from draft once MauroDataMapper/mdm-core branch feature/mc-9801 has been merged.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

olliefreeman
olliefreeman previously approved these changes Feb 16, 2022
Copy link
Contributor

@olliefreeman olliefreeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Develop core branch is merged. This is good to go from my side

@pjmonks pjmonks marked this pull request as ready for review February 16, 2022 13:53
* Folders returned for the tree root no longer auto-expand, so ensure that every container can be expanded on request
* Send modelCreatableOnly param for the tree view in the import screens
@jamesrwelch
Copy link
Contributor

Folder contents are no-longer appearing in alphabetical order. Is an extra parameter to the endpoint required? @olliefreeman @pjmonks
Otherwise, seems to work just fine. I wonder whether a future improvement might be to retrieve and cache some of the folders in the background, so that expanding is quicker. But overall a nice speed improvement.
Screenshot 2022-02-17 at 14 14 19

@pjmonks
Copy link
Contributor Author

pjmonks commented Feb 17, 2022

@olliefreeman Is there a query parameter I can send to api/tree/folders/{id} to sort the list?

@olliefreeman
Copy link
Contributor

theres no optoins to change it its hardcoded
folders are always alphabetical
models should be as well
however DM content (DCs) "should" be returned as alphabetical childless then alphabetical parents

however ... i saw this exact problem the other day...im wondering if something i changed somehow caused the ordering ("sort") call to not be made, prob best to raise a bug on mdm-core and say that folders do not appear to being sorted properly in the tree. Then i'll fix it asap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants