Subscribed Catalogue changes to support multiple Authentication Types

[joe-crawford]

• Display versions (or model version tags) for Published Models in the tree entry for a Subscribed Catalogue.
• In the Subscribed Catalogue admin settings page, add fields to choose Authentication Type and required authentication fields for each type (No Authentication, API Key or OAuth (Client Credentials)).

Depends on MauroDataMapper/mdm-resources#84.

[joe-crawford]

Screenshots after changes:

Subscribed Catalogues list in Admin Settings (/admin/subscribedCatalogues):

Subscribed Catalogue entry/update page (/admin/subscribedCatalogue/{{id}}):

Subscribed Catalogue tree view:

...

[jamesrwelch]

One typescript error, and a couple of minor issues after merging and upgrading to latest Typescript. I'm happy to take a look myself and fix before accepting

[jamesrwelch]

This all seems to work well, and the tests pass and the linting succeeds - good job! One minor change, please - the styling of the hint "The syndication feed URL to connect to" makes it unclear where the hint should go, or what it relates to. Are you able to add some spacing or something? This may be a more general problem with hints that we should resolve globally at a later date.

[jamesrwelch]

Looks much better, works much better. Great work!

[jamesrwelch]

@joe-crawford Not sure what's going on with the conflicts though 😕

[joe-crawford]

@jamesrwelch sorry I have a fix for this but the commit is not finished yet :) Sent from Outlook for Android<https://aka.ms/AAb9ysg>

…

________________________________ From: James Welch ***@***.***> Sent: Friday, February 3, 2023 7:39:59 PM To: MauroDataMapper/mdm-ui ***@***.***> Cc: Joe Crawford ***@***.***>; Mention ***@***.***> Subject: Re: [MauroDataMapper/mdm-ui] Subscribed Catalogue changes to support multiple Authentication Types (PR #737) @joe-crawford<https://github.com/joe-crawford> Not sure what's going on with the conflicts though 😕 — Reply to this email directly, view it on GitHub<#737 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AICTVW7UO4FA7ULGGROFGVDWVVNI7ANCNFSM6AAAAAAUFH7VQU>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[joe-crawford]

Latest commit has a rebase and adds some padding to the field captions, and fixes an issue with the required field validation when toggling between different authentication types.

[jamesrwelch]

Really great piece of work - nice one!