fix: set div_is_floordiv to False to avoid bad casts

Mause · Jan 8, 2025 · dfbed6d · dfbed6d
1 parent 5bf8a59
commit dfbed6d
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/duckdb_engine/__init__.py b/duckdb_engine/__init__.py
@@ -237,8 +237,8 @@ class Dialect(PGDialect_psycopg2):
     supports_comments = has_comment_support()
     supports_sane_rowcount = False
     supports_server_side_cursors = False
+    div_is_floordiv = False  # TODO: tweak this to be based on DuckDB version
     inspector = DuckDBInspector
-    # colspecs TODO: remap types to duckdb types
     colspecs = util.update_copy(
         PGDialect.colspecs,
         {

diff --git a/duckdb_engine/tests/test_datatypes.py b/duckdb_engine/tests/test_datatypes.py
@@ -25,7 +25,7 @@
 from sqlalchemy.ext.declarative import declarative_base
 from sqlalchemy.orm import Session
 from sqlalchemy.sql import sqltypes
-from sqlalchemy.types import JSON
+from sqlalchemy.types import FLOAT, JSON
 
 from .._supports import duckdb_version, has_uhugeint_support
 from ..datatypes import Map, Struct, types
@@ -238,3 +238,13 @@ def test_interval(engine: Engine, snapshot: SnapshotTest) -> None:
     test_table = Table("test_table", MetaData(), Column("duration", Interval))
 
     assert "duration INTERVAL" in str(schema.CreateTable(test_table).compile(engine))
+
+
+def test_div_is_floordiv(engine: Engine) -> None:
+    test_table = Table(
+        "test_table", MetaData(), Column("value", FLOAT), Column("eur2usd_rate", FLOAT)
+    )
+
+    stmt = test_table.c.value / test_table.c.eur2usd_rate
+
+    assert str(stmt.compile(engine)) == "test_table.value / test_table.eur2usd_rate"