Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump duckdb version #115

Merged
merged 1 commit into from
Aug 7, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 1 addition & 21 deletions duckdb_engine/__init__.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from typing import Any, Dict, List, Optional, Tuple, Type
from typing import Any, Dict, List, Tuple, Type

import duckdb
from sqlalchemy.dialects.postgresql import dialect as postgres_dialect
Expand Down Expand Up @@ -58,26 +58,6 @@ def close(self) -> None:
# duckdb doesn't support 'soft closes'
pass

@property
def description(
self,
) -> Optional[
# TODO: remove this override once the next version of duckdb is released
Tuple[
str,
str,
Optional[str],
Optional[str],
Optional[str],
Optional[str],
Optional[str],
]
]:
try:
return self.c.description
except RuntimeError:
return None

def executemany(
self, statement: str, parameters: List[Dict] = None, context: Any = None
) -> None:
Expand Down
5 changes: 0 additions & 5 deletions duckdb_engine/tests/test_basic.py
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,6 @@ def test_get_check_constraints(inspector: PGInspector) -> None:
inspector.get_check_constraints("test", None)


@mark.xfail(reason="reflection not yet supported in duckdb", raises=NotImplementedError)
def test_get_unique_constraints(inspector: PGInspector) -> None:
inspector.get_unique_constraints("test", None)

Expand All @@ -143,16 +142,12 @@ def test_table_reflect(session: Session, engine: Engine) -> None:
insp.reflect_table(user_table, None)


@mark.xfail(reason="current duckdb release doesnt support size param", raises=TypeError)
def test_fetch_df_chunks() -> None:
import duckdb

duckdb.connect(":memory:").execute("select 1").fetch_df_chunk(1)


@mark.xfail(
reason="current duckdb release doesnt support size param", raises=RuntimeError
)
def test_description() -> None:
import duckdb

Expand Down
Loading