-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support getting table properties using schema with db name prefix #848
fix: support getting table properties using schema with db name prefix #848
Conversation
…nique_constraints and add UTs
@Mause, this is now ready for review. I added a method |
…ecting-db-nameschema-from-ui
Please review/merge this PR to address this issue: apache/superset#26286 duckdb/duckdb#10033 |
With the introduction of PR #835 a user might want to fully specify a schema with the database name as prefix, i.e.
"my db"."my schema"
.This PR fixes a bug that currently prevents usage of
Dialect.has_table
,Dialect.get_table_names
,Dialect.get_columns
,Dialect.get_foreign_keys
andDialect.get_check_constraints
when using said fully specified schema name.I also refactored
test_get_schema_names
so there is a separate test forget_table_names
.Edit: This fixes duckdb/duckdb#10033