Translation Field in request query and some optional fix #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…MaxHasADHD-master # Conflicts: # Common/Models/Shows/TraktShowTranslation.swift
|
Thank you for this! Sorry it has taken awhile to respond. I'm conflicted on merging because I'm not sure if I want those properties to be optional or to add another type without those properties, to make it more clear about the expectation of what is returned and when, and less unwrapping when you know the data is available. I'll have to think about this a bit and check the documentation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the field translations in the request for seasons and episodes and fixed some optional values marked as required