Fix DatePickerAndroid error when passing "minDate: null" #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It avoids an error when passing an `options` object with `minDate: null`. Inspired by isObjectLike from Loadash (https://github.com/lodash/lodash/blob/4.17.10/lodash.js#L11771-L11773).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes facebook#21253
It avoids an error when passing an
optionsobject withminDate: null. (see facebook#21253)Inspired by isObjectLike from Loadash.
Test Plan:
This jsbin allow to test the old and the new
_toMillisfunction.You can observe that
_toMillisdoesn't throw error (fixed) and that if you decomment the_toMillis_before_prcall, it will generate an error as before.Release Notes:
[ANDROID] [BUGFIX] [DatePickerAndroid] fix error when passing "minDate: null"