Require Active Support rather than Rails #3
Conversation
| @@ -15,7 +15,7 @@ Gem::Specification.new do |s| | |||
| s.files = Dir['{app,config,db,lib}/**/*', 'MIT-LICENSE', 'Rakefile', 'README.rdoc'] | |||
| s.test_files = Dir['test/**/*'] | |||
|
|
|||
| s.add_dependency 'rails', '~> 4.0' | |||
| s.add_dependency 'activesupport', '~> 4.2.0' | |||
There was a problem hiding this comment.
I don't think you wanted to change the dependency to be a 4.2.0, because now anyone on Rails 4.1.x can't use this. No?
There was a problem hiding this comment.
Yeah my mistake here. I'll update.
|
I also added a CHANGELOG, mind adding a line to it, please? |
|
Hm.. I like the idea but the name of the gem is confusing then :\ |
|
@Maxim-Filimonov that is indeed a more existential question here... |
|
LGTM! @dblock all good? |
|
This is good, lets merge. I'll cut a release. |
Require Active Support rather than Rails
|
@Maxim-Filimonov I don't have Rubygems access for this one, could you please run |
|
Thanks @dblock and @Maxim-Filimonov! |
|
@dblock Ah sorry :\ Just added you. |
|
Released 0.0.2. |
It would be nice to take advantage of hashie_rails without needing to include Rails in a project (in a Grape + Rack app for example). It appears that ActiveSupport is the actual dependency here. This moves Rails to development dependency.