Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reasons to use this project vs googleapis/google-api-nodejs-client #22

Merged
merged 4 commits into from
Feb 18, 2020

Conversation

Maxim-Mazurok
Copy link
Owner

While searching for DialogFlow libs, I rediscovered this project: https://github.com/googleapis/google-api-nodejs-client

It has virtually all Google APIs written in TypeScript. But you can't use it on client-side (because it uses fs) and it doesn't have client-side auth lib and client lib

Please, let me know what made you use this project. Am I missing any reasons?

Copy link
Collaborator

@namoscato namoscato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine, but would it make sense to focus on clarifying that this project is intended to generate type definitions for google-api-javascript-client (gapi)? I feel like the Node.js explanation could cause more confusion.

Ultimately up to you, I don't have a huge preference either way.

@declanvong
Copy link
Collaborator

Yep, in mine I just said These definitions are for the Google API Javascript Client: https://github.com/google/google-api-javascript-client and that was about it. I think your explanation is fine though.

TLDR is just google-api-nodejs-client != google-api-javascript-client, right?

@Maxim-Mazurok
Copy link
Owner Author

Thank you guys a lot! I finally wrapped my head around how the things work with these APIs.
Please, check the updated version.

would it make sense to focus on clarifying that this project is intended to generate type definitions for gapi?

Yes, in this update I tried to make it clear and moved focus to gapi.

TLDR is just google-api-nodejs-client != google-api-javascript-client, right?

Right, I just wasn't really sure what the key differences are.
Basically, client libraries are generated on the fly from discovery service by gapi, which is closed-source.

Copy link
Collaborator

@namoscato namoscato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

We should chat with the gapi guys soon if we have not already to see if we can get their "official" buy in for this project.

@Maxim-Mazurok Maxim-Mazurok merged commit 80dce76 into master Feb 18, 2020
@Maxim-Mazurok Maxim-Mazurok deleted the Maxim-Mazurok-patch-1 branch February 18, 2020 11:10
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants